feat: error handler improvements #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
force-pushed
the
error-handling-improvements
branch
from
e268d73 to
b15a63c
Compare
metacosm
reviewed
Mar 14, 2022
...mework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ErrorStatusHandler.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
Mar 14, 2022
| } | ||
| }); | ||
| } catch (Exception e) { | ||
| throw new IllegalStateException(e); |
There was a problem hiding this comment.
Why IllegalStateException?
There was a problem hiding this comment.
Changed it to OperatorException.
| try { | ||
| return execution.execute(); | ||
| } catch (Exception e) { | ||
| throw new IllegalStateException(e); |
There was a problem hiding this comment.
Why throw an IllegalStateException here?
There was a problem hiding this comment.
Changed it to OperatorException.
There was a problem hiding this comment.
The goal is to wrap it to a runtime exception (but not the RuntimeException), not sure what is the best approach.
…tor/api/reconciler/ErrorStatusHandler.java Co-authored-by: Chris Laprun <[email protected]>
…r-sdk/java-operator-sdk into error-handling-improvements
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.