fix: renaming mapper primary <-> secondary #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

csviri merged 1 commit into next from association-mapper-api-renames

Mar 11, 2022

Collaborator

csviri commented Mar 10, 2022

@metacosm what do you think about this renaming. Not sure how much actual backwards compatibiilty issues it will make since usually implemented as lambda function. But we can document these minor changes.
The current names are very obscure for me, have to think about every time I check.

Also would add glossary page to the web page docs, to cleary define:

Secondary Resource (what is a resource actually controller creates)
Dependent Resource (is the dependent resource feature)

If you agree.
Later we can extend glossary with additional notions.


          fix: renaming mapper primary <-> secondary

add49be

csviri self-assigned this

sonarqubecloud bot commented Mar 10, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
53 Code Smells

36.6% Coverage
0.0% Duplication

metacosm approved these changes

View reviewed changes

Collaborator

metacosm left a comment

That's fine with me. The old names were indeed confusing. That said, the new names are not that much better but I don't have any better proposal. 😬

csviri merged commit b358329 into next

csviri deleted the association-mapper-api-renames branch

March 11, 2022 08:11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet