Skip to content

feat: throw exception if desired is null #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2022
Merged

feat: throw exception if desired is null #1180

merged 3 commits into from
Apr 26, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 25, 2022

No description provided.

@csviri csviri self-assigned this Apr 25, 2022
@csviri csviri requested a review from metacosm April 25, 2022 08:03
@csviri csviri linked an issue Apr 25, 2022 that may be closed by this pull request
Improper validation of returned values in AbstractDependentResource #1179
Closed
@metacosm
Copy link
Collaborator

I'd don't think that this is enough. The issue occurred when handleCreate returned null. If you look at the code for the MySQL sample in the Quarkus extension you'll see that it's actually create that returns null.

@csviri
Copy link
Collaborator Author

csviri commented Apr 25, 2022

I'd don't think that this is enough. The issue occurred when handleCreate returned null. If you look at the code for the MySQL sample in the Quarkus extension you'll see that it's actually create that returns null.

good point will add check there too

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

70.6% 70.6% Coverage
0.0% 0.0% Duplication

@csviri
Copy link
Collaborator Author

csviri commented Apr 25, 2022

updated.

metacosm
metacosm approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit 4f7daa4 into main Apr 26, 2022
@csviri csviri deleted the dr-create-update-nullcheck branch April 26, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper validation of returned values in AbstractDependentResource
2 participants
@csviri @metacosm