refactor: clean namespaces constants #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metacosm
commented
May 10, 2022
metacosm
commented
- refactor!: move SAME_AS_CONTROLLER constant to Constants class, add set
- refactor!: rename WATCH_CURRENT_NAMESPACE_SET to match other constants
csviri
reviewed
May 11, 2022
| @@ -7,13 +7,17 @@ public final class Constants { | |||
|
|
|||
| public static final Set<String> DEFAULT_NAMESPACES = | |||
| Collections.singleton(Constants.WATCH_ALL_NAMESPACES); | |||
| public static final Set<String> WATCH_CURRENT_NAMESPACE_SET = | |||
| public static final Set<String> WATCH_CURRENT_NAMESPACES = | |||
There was a problem hiding this comment.
Not sure about this, in this simple plural form it says we can watch more current namespace. While the case is that this is only a helper to wrap the WATCH_CURRENT_NAMESPACE. That is why I just added the SET suffix.
There was a problem hiding this comment.
Then let's rename all the Set constants with the _SET suffix
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.