Skip to content

feat: cover more cases when trying to determine generic types #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Jun 7, 2022

No description provided.

@metacosm metacosm self-assigned this Jun 7, 2022
@metacosm metacosm requested a review from csviri June 7, 2022 19:35
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

made just one comment about an exception type to throw might be different

}
return getFirstTypeArgumentFromInterface(clazz, expectedImplementedInterface);
} catch (Exception e) {
throw new RuntimeException(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe throw OperatorException here?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

73.0% 73.0% Coverage
0.0% 0.0% Duplication

@metacosm metacosm merged commit 99b5ecd into main Jun 9, 2022
@metacosm metacosm deleted the better-error-message branch June 9, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants