refactor: ReconciliationMaxInterval -> MaxReconciliationInterval #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should not we just rename this? and put it into migration guide also. It will look quite ugly in the main APIs. Doubting that much people using this, and it is easy to migrate. |
|
Not sure if the wording is even better this way tbh. |
The current wording doesn't follow English rules :) |
|
fair enough :) |
csviri
reviewed
Jul 15, 2022
| @@ -39,6 +49,9 @@ | |||
| public class AnnotationControllerConfiguration<P extends HasMetadata> | |||
| implements io.javaoperatorsdk.operator.api.config.ControllerConfiguration<P> { | |||
|
|
|||
| private static final Logger log = | |||
csviri
approved these changes
Jul 15, 2022
| /** | ||
| * @deprecated use {@link #NO_MAX_RECONCILIATION_INTERVAL} instead | ||
| */ | ||
| @Deprecated(forRemoval = true) | ||
| public static final long NO_RECONCILIATION_MAX_INTERVAL = -1L; |
There was a problem hiding this comment.
This can be removed I guess
|
Kudos, SonarCloud Quality Gate passed! |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.