Skip to content

fix: cleaner issue for pod caused by missing generation in metadata #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 16, 2022
Merged

fix: cleaner issue for pod caused by missing generation in metadata #1600

merged 8 commits into from
Nov 16, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Nov 15, 2022 •
edited
Loading

closes: #1599

@csviri csviri self-assigned this Nov 15, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

36.4% 36.4% Coverage
0.0% 0.0% Duplication

@csviri
Copy link
Collaborator Author

csviri commented Nov 16, 2022

At the end changed the integration tests to use Service instead of Pod (what has the same issue), because it results in much more stable test.

@csviri csviri merged commit b7dffeb into main Nov 16, 2022
@csviri csviri deleted the pod-cleaner-issue branch November 16, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cleanup is only called on restart
2 participants
@csviri @metacosm