feat: workflows can be created without associated dependent resource #1632
Conversation
This allows for the workflow graph to be resolved at build time from a factory, the dependent resources being injected as needed at runtime via the resolve mechanism.
| @@ -64,4 +64,8 @@ default Optional<R> getSecondaryResource(P primary, Context<P> context) { | |||
| static String defaultNameFor(Class<? extends DependentResource> dependentResourceClass) { | |||
| return dependentResourceClass.getName(); | |||
| } | |||
|
|
|||
| static boolean canDeleteIfAble(DependentResource<?, ?> dependentResource) { | |||
There was a problem hiding this comment.
this naming somehow feels strange
There was a problem hiding this comment.
What would you name it?
There was a problem hiding this comment.
Also problem here is that GarbageCollected is only applicatble for KubernetesDependentResource, so it is little smelly that it's on this layer.
There was a problem hiding this comment.
Yeah, wasn't too sure where to put it but the problem is that the code in this method was spread at different spots that didn't have anything to do with KubernetesDependentResource either so it's less smelly now than it was.
| @@ -64,4 +64,8 @@ default Optional<R> getSecondaryResource(P primary, Context<P> context) { | |||
| static String defaultNameFor(Class<? extends DependentResource> dependentResourceClass) { | |||
| return dependentResourceClass.getName(); | |||
| } | |||
|
|
|||
| static boolean canDeleteIfAble(DependentResource<?, ?> dependentResource) { | |||
| return dependentResource instanceof Deleter && !(dependentResource instanceof GarbageCollected); | |||
There was a problem hiding this comment.
Would rather just check Deleter here. And override this is KubernetesDependentResource and check there also the GarbageCOllected as here. So it more expresses that GarbageCollected just applies on KubernetesDependentResource
There was a problem hiding this comment.
This isn't the case in the tests, though…
|
Kudos, SonarCloud Quality Gate passed! |
This allows for the workflow graph to be resolved at build time from a
factory, the dependent resources being configured as needed at runtime
via the resolve mechanism.