refactor: simplify controller configuration #1635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metacosm
commented
Nov 29, 2022
metacosm
commented
- refactor: move configuration processing to BaseConfigurationService
- feat: add validation method on interfaces instead of implementations
- fix: properly set deprecated filters when overriding configuration
csviri
reviewed
Dec 2, 2022
...-core/src/main/java/io/javaoperatorsdk/operator/api/config/DefaultResourceConfiguration.java
Outdated
Show resolved
Hide resolved
...t/java/io/javaoperatorsdk/operator/config/runtime/AnnotationControllerConfigurationTest.java
Outdated
Show resolved
Hide resolved
...work-core/src/main/java/io/javaoperatorsdk/operator/api/config/BaseConfigurationService.java
Show resolved
Hide resolved
metacosm
force-pushed
the
simplify-controller-configuration-2
branch
from
707d139 to
d8f3ace
Compare
csviri
approved these changes
Dec 5, 2022
metacosm
force-pushed
the
simplify-controller-configuration-2
branch
from
d8f3ace to
6d51e0e
Compare
Replaced all the different controller configuration implementations by only one: ResolvedControllerConfiguration.
metacosm
force-pushed
the
simplify-controller-configuration-2
branch
from
6d51e0e to
bda268e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
added a commit
that referenced
this pull request
Dec 14, 2022
* refactor: move configuration processing to BaseConfigurationService Replaced all the different controller configuration implementations by only one: ResolvedControllerConfiguration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.