feat: feat controller queue size, execution thread count #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
metacosm
requested changes
Dec 6, 2022
...pport/src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetrics.java
Outdated
Show resolved
Hide resolved
metacosm
reviewed
Dec 9, 2022
| @@ -118,6 +168,12 @@ public void failedReconciliation(HasMetadata resource, Exception exception, | |||
| return registry.gaugeMapSize(PREFIX + name + ".size", Collections.emptyList(), map); | |||
| } | |||
|
|
|||
| private List<Tag> gvkTags(Class<? extends HasMetadata> resourceClass) { | |||
There was a problem hiding this comment.
There are several spots where GVK information is added to tags. Could this method be reused elsewhere? Also, it looks like sometimes it's prefixed with resource, sometimes not…
There was a problem hiding this comment.
gauge is a little different than others, since it is first needs to initialized. Then incremented or decremented. This is specially needed for that. But made it at least public static for now.
There was a problem hiding this comment.
Also, it looks like sometimes it's prefixed with resource, sometimes not…
what do you mean exactly?
metacosm
requested changes
Dec 9, 2022
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
approved these changes
Dec 9, 2022
csviri
added a commit
that referenced
this pull request
Dec 9, 2022
metacosm
pushed a commit
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.