Skip to content

fix: non-independent unit tests because static state #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Dec 20, 2022

This fixes an issue with unit tests where order matters. But state state should be avoided in the future, also this refactored.

@csviri csviri self-assigned this Dec 20, 2022
@csviri csviri requested a review from metacosm December 20, 2022 14:07
@csviri csviri force-pushed the local-unit-test-fix branch from ff5410a to f120a6d Compare December 21, 2022 10:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit 53a553e into main Dec 21, 2022
@csviri csviri deleted the local-unit-test-fix branch December 21, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant