Skip to content

fix: remove exception on delete event #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Dec 25, 2022

No description provided.

@csviri csviri self-assigned this Dec 25, 2022
@csviri csviri linked an issue Dec 25, 2022 that may be closed by this pull request
@csviri csviri requested a review from metacosm December 25, 2022 20:08
@csviri
Copy link
Collaborator Author

csviri commented Dec 25, 2022

Delete event should always get propagated to EventProcessor. See also related issue

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@csviri
Copy link
Collaborator Author

csviri commented Dec 25, 2022

(will add unit test and/or make this more explicit when back from holidays)

@csviri csviri merged commit e73c98e into main Dec 28, 2022
@csviri csviri deleted the fix-delete-event-processing branch December 28, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previous operator version of custom resources don't get deleted
1 participant