Skip to content

fix: update deprecated client usage and minor improvements #1707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 6, 2023

No description provided.

@csviri csviri self-assigned this Jan 6, 2023
@csviri csviri requested a review from metacosm January 10, 2023 09:04
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from very minor comment :)

@@ -75,7 +77,7 @@ public Map<String, EventSource> prepareEventSources(
return Set.of(new ResourceID(name.toString(), s.getMetadata().getNamespace()));
}).build();
InformerEventSource<ConfigMap, MultipleSecondaryEventSourceCustomResource> configMapEventSource =
new InformerEventSource<ConfigMap, MultipleSecondaryEventSourceCustomResource>(config,
new InformerEventSource<>(config,
context);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be put on the same line as the previous one, imo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

54.5% 54.5% Coverage
0.0% 0.0% Duplication

@csviri csviri merged commit 3ab42bf into main Jan 10, 2023
@csviri csviri deleted the inspection-fixes branch January 10, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants