feat: Made ConfigurationServiceOverrider to accept dependent resource factory #2175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rameshmalla
force-pushed
the
dependent-resource-factory-input
branch
from
3027de9 to
65b12af
Compare
…factory Signed-off-by: Ramesh Malla <[email protected]>
rameshmalla
force-pushed
the
dependent-resource-factory-input
branch
from
65b12af to
157d74e
Compare
Signed-off-by: Ramesh Malla <[email protected]>
Signed-off-by: Ramesh Malla <[email protected]>
|
Hi @csviri I fixed the code format issue, if it's ok with you could you approve the workflows. |
csviri
approved these changes
Dec 27, 2023
|
👍 |
csviri
pushed a commit
that referenced
this pull request
Jan 8, 2024
…ctory (#2175) * feat:Made ConfigurationServiceOverrider to accept dependent resource factory Signed-off-by: Ramesh Malla <[email protected]> * Code refactor Signed-off-by: Ramesh Malla <[email protected]> * Format code Signed-off-by: Ramesh Malla <[email protected]> --------- Signed-off-by: Ramesh Malla <[email protected]> Co-authored-by: Ramesh Malla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #2166.
The idea here is to modify
ConfigurationServiceOverriderto accept implementations ofDependentResourceFactory. This modification can then be utilized by OperatorAutoConfiguration in josdk-spring-boot-starte to inject a Spring-awareDependentResourceFactory.Note: I made this change with a high-level understanding of the codebase. I am open to learning and adjusting the changes based on suggestions if they do not align with the future plans of the library.