Skip to content

Support Parameterized abstract controllers #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

s-soroosh
Copy link
Contributor

closes #254

@s-soroosh s-soroosh requested a review from metacosm December 11, 2020 14:41
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe add some documentation on the annotation processor logic?

@s-soroosh
Copy link
Contributor Author

LGTM but maybe add some documentation on the annotation processor logic?

Sure, I'll document what the involved classes are doing.

Soroosh Sarabadani added 3 commits December 13, 2020 11:31
…processor

# Conflicts:
#	operator-framework/src/main/java/io/javaoperatorsdk/operator/processing/annotation/ControllerAnnotationProcessor.java
#	operator-framework/src/test/resources/AbstractController.java
@s-soroosh s-soroosh requested a review from csviri December 14, 2020 09:32
@s-soroosh s-soroosh changed the title Support Parameterize abstract controllers Support Parameterized abstract controllers Dec 14, 2020
@s-soroosh s-soroosh merged commit 39c00ef into operator-framework:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The annotation processor does not work for Parameterized abstract controllers.
2 participants