Make ObjectMapper of CustomResourceCache configurable #385
Conversation
|
Addressing #384 |
...framework-core/src/main/java/io/javaoperatorsdk/operator/processing/CustomResourceCache.java
Outdated
Show resolved
Hide resolved
i8r
force-pushed
the
object-mapper
branch
4 times, most recently
from
9edbb08 to
a172883
Compare
There was a problem hiding this comment.
Please use conventional commits (https://www.conventionalcommits.org/en/v1.0.0/) for commit messages.
...framework-core/src/main/java/io/javaoperatorsdk/operator/processing/CustomResourceCache.java
Show resolved
Hide resolved
...framework-core/src/main/java/io/javaoperatorsdk/operator/processing/CustomResourceCache.java
Outdated
Show resolved
Hide resolved
| @@ -49,18 +58,13 @@ public void cacheResource(CustomResource resource, Predicate<CustomResource> pre | |||
| * @return | |||
| */ | |||
| public Optional<CustomResource> getLatestResource(String uuid) { | |||
| return Optional.ofNullable(clone(resources.get(uuid))); | |||
| return Optional.ofNullable(resources.get(uuid)).map(this::clone); | |||
There was a problem hiding this comment.
Strictly speaking this is still unrelated. I'll undo it as well if you prefer.
|
Comments addressed and commit history cleaned up. |
...ework-core/src/test/java/io/javaoperatorsdk/operator/processing/DefaultEventHandlerTest.java
Outdated
Show resolved
Hide resolved
...ava/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSourceTest.java
Outdated
Show resolved
Hide resolved
...ava/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSourceTest.java
Outdated
Show resolved
Hide resolved
...ework-core/src/test/java/io/javaoperatorsdk/operator/processing/DefaultEventHandlerTest.java
Outdated
Show resolved
Hide resolved
|
Can you please fix the typo in the commit message? Otherwise, this looks good to me. |
i8r
changed the title
Of course. I also addressed the other comments. |
|
Sorry to be a bother but now the commit message doesn't follow the conventional commit format anymore… 😢 |
* Optionally provide the ObjectMapper in the constructor of the Operator * Optionally provide the ObjectMapper in constructor of the CustomResourceCache * Optionally autowire a ObjectMapper in spring boot
Oh no, you are right. Sorry for messing up the commit message multiple times 😄 |
|
Thank you! |
Uh oh!
There was an error while loading. Please reload this page.