fix: only throw MissingCRDException if we get a 404 on the target CRD #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM wonder if the MissingCRDException should only be thrown by the CustomResourceEventHanderl instead of any event source |
csviri
reviewed
Sep 23, 2021
| @@ -92,7 +95,10 @@ public final void registerEventSource(String name, EventSource eventSource) | |||
| if (e instanceof KubernetesClientException) { | |||
There was a problem hiding this comment.
Should not we catch this exception and make these checks in the CustomResourceEventSource?
(And just throw the exception further if this is not the exception we want to trasnlate)
csviri
reviewed
Sep 23, 2021
| @@ -92,7 +95,10 @@ public final void registerEventSource(String name, EventSource eventSource) | |||
| if (e instanceof KubernetesClientException) { | |||
| KubernetesClientException ke = (KubernetesClientException) e; | |||
| if (404 == ke.getCode()) { | |||
There was a problem hiding this comment.
I mean this logic. This is quite specific to CustomResourceEventSource. Cannot be moved there?
metacosm
force-pushed
the
fix-missing-crd-exception
branch
from
0b9cee8 to
a899a4c
Compare
This indeed makes more sense like this as this should only happen when attempting to register watches for the primary resources.
csviri
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this relies on fabric8io/kubernetes-client#3492 so won't build
until this PR is merged and available in a release.
Fixes #552