Skip to content

Fix generics #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

Fix generics #634

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5431289
chore(deps): bump micrometer-core from 1.7.4 to 1.7.5 (#606)
dependabot[bot] Oct 15, 2021
30dcf72
fix: re-schedule generics (#614)
csviri Oct 20, 2021
f9ee9b2
chore(deps): bump spring-boot.version from 2.5.5 to 2.5.6 (#617)
dependabot[bot] Oct 22, 2021
fb15a1e
chore(deps): bump awaitility from 4.1.0 to 4.1.1
dependabot[bot] Oct 26, 2021
f188473
fix: prevent double registration of same CR with different controllers
metacosm Oct 26, 2021
b437fef
Informer based CustomResourceEventSource and caching (#581)
csviri Oct 12, 2021
6a3503a
chore: update version to 2.0.0-SNAPSHOT
metacosm Oct 12, 2021
f4b6b7f
Reschedule delete (#600)
csviri Oct 13, 2021
1c9f257
Refined Interface of `EventSource` and `EventSourceManager` (#597)
csviri Oct 13, 2021
cb62f6c
Removing events from context (#596)
csviri Oct 13, 2021
7fc1c64
fix: cache handling on update (#604)
csviri Oct 20, 2021
60660ed
feat: Only one scheduled event (re-schedul / retry) at one time (#609)
csviri Oct 20, 2021
bea733d
feat: Cloner interface for Custom Resource instead of ObjectMapper (#…
csviri Oct 20, 2021
1a3558b
fix: EventSourceManager and ResourceController interface enhancements…
csviri Oct 26, 2021
8199a05
feat!: adapt monitoring code to new implementation
metacosm Oct 21, 2021
a5c481b
feat: removing Event using DefaultEvent instead, renamed DefaultEvent…
csviri Oct 27, 2021
d244948
refactor!: replace Closeable by explicit Stoppable interface
metacosm Oct 27, 2021
d857aca
refactor: fix generics
metacosm Oct 27, 2021
77b6556
chore: clean-up
metacosm Oct 27, 2021
ec53e03
fix: potential performance issue
metacosm Oct 27, 2021
fba211e
chore: clean-up
metacosm Oct 27, 2021
81412a6
fix: more generics fixes
metacosm Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: potential performance issue
  • Loading branch information
@metacosm
metacosm committed Oct 28, 2021
commit ec53e03907cc2756cb359cc8e8ec48cb8113a60e
2 changes: 1 addition & 1 deletion ...rc/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public ControllerConfigurationOverrider<R> addingNamespaces(String... namespaces
}

public ControllerConfigurationOverrider<R> removingNamespaces(String... namespaces) {
this.namespaces.removeAll(List.of(namespaces));
List.of(namespaces).forEach(this.namespaces::remove);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intellij was complaning for me too about this, but not undertand why would this have better performance.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess removeAll repeatedly calls contains on the whole passed collection, while removing one by one only needs to do it for each elements?

return this;
}

Expand Down