Improve cache interface for CustomResourceEventSource #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
csviri
changed the title
# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java # sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java
metacosm
reviewed
Nov 16, 2021
|
|
||
| public Stream<T> getCachedCustomResources(Predicate<T> predicate) { |
There was a problem hiding this comment.
That seems like a very inefficient method.
There was a problem hiding this comment.
Changed it to a way how it's doable nicely with current java APIs but not sure it's actually much more efficient;
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
…k/java-operator-sdk into improve-cache-interface
|
Should we close this? |
or merge it? |
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
metacosm
force-pushed
the
improve-cache-interface
branch
from
721fec0 to
084e39a
Compare
metacosm
added
the
kind/feature
metacosm
approved these changes
Nov 26, 2021
…prove-cache-interface # Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/ControllerResourceEventSource.java # sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java
metacosm
force-pushed
the
improve-cache-interface
branch
from
5b8af3d to
36bbd4b
Compare
…ource" This reverts commit 574daaa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.