-
Notifications
You must be signed in to change notification settings - Fork 219
Improve cache interface for CustomResourceEventSource #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java # sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java
|
||
public Stream<T> getCachedCustomResources(Predicate<T> predicate) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems like a very inefficient method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to a way how it's doable nicely with current java APIs but not sure it's actually much more efficient;
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
…k/java-operator-sdk into improve-cache-interface
Should we close this? |
or merge it? |
fixed informer bug and related IT as part of this commit Co-authored-by: Chris Laprun <[email protected]> Co-authored-by: Attila Mészáros <[email protected]> Co-authored-by: Adam Sándor <[email protected]>
721fec0
to
084e39a
Compare
…prove-cache-interface # Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/ControllerResourceEventSource.java # sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java
5b8af3d
to
36bbd4b
Compare
…ource" This reverts commit 574daaa
No description provided.