Skip to content

Improve cache interface for CustomResourceEventSource #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 29, 2021

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Nov 15, 2021

No description provided.

adam-sandor and others added 2 commits November 15, 2021 16:04
fixed informer bug and related IT as part of this commit

Co-authored-by: Chris Laprun <[email protected]>
Co-authored-by: Attila Mészáros <[email protected]>
Co-authored-by: Adam Sándor <[email protected]>
@csviri csviri changed the title Improve cache interface Improve cache interface for CustomResourceEventSource Nov 15, 2021
@csviri csviri self-assigned this Nov 16, 2021
# Conflicts:
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java
#	sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java

public Stream<T> getCachedCustomResources(Predicate<T> predicate) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a very inefficient method.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to a way how it's doable nicely with current java APIs but not sure it's actually much more efficient;

@csviri csviri requested a review from metacosm November 17, 2021 09:45
Base automatically changed from v2 to master November 24, 2021 13:21
@metacosm
Copy link
Collaborator

Should we close this?

@csviri
Copy link
Collaborator Author

csviri commented Nov 26, 2021

Should we close this?

or merge it?
Added some other utility method, those can be quite handy, but we can also evaluate in M2, how to handle this more smart in with some EventSource events.

@metacosm metacosm force-pushed the improve-cache-interface branch from 721fec0 to 084e39a Compare November 26, 2021 14:44
@metacosm metacosm self-assigned this Nov 26, 2021
@metacosm metacosm added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 26, 2021
csviri and others added 3 commits November 26, 2021 15:51
…prove-cache-interface

# Conflicts:
#	operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/ControllerResourceEventSource.java
#	sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java
@metacosm metacosm force-pushed the improve-cache-interface branch from 5b8af3d to 36bbd4b Compare November 26, 2021 16:42
@csviri csviri merged commit 80ff244 into main Nov 29, 2021
@csviri csviri deleted the improve-cache-interface branch November 29, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants