fix: resource cache interface for InformerEventSource #758
Conversation
| @@ -56,8 +50,8 @@ protected void handleEvent(T value, ResourceID relatedResourceID) { | |||
| } | |||
| } | |||
|
|
|||
| public Cache<ResourceID, T> getCache() { | |||
| return cache; | |||
| public Map<ResourceID, T> getCache() { | |||
There was a problem hiding this comment.
I think this is too restrictive… I think we should probably simplify ResourceCache and return that instead maybe?
There was a problem hiding this comment.
Not sure if following, we return all the values, can it be less restrictive?
On the other hand the resource cache is now about K8S resource, and this class is dedicated to non k8s resources. So not sure if we should unify those. Those have totally different requirements. And approach how we are handling them.
There was a problem hiding this comment.
Or maybe just a very simple way.
Like having a simple interface with one method
getValue(ResourceID id)
There was a problem hiding this comment.
This will be addressed in a subsequent PR, let's merge this as-is for now.
| @@ -56,8 +50,8 @@ protected void handleEvent(T value, ResourceID relatedResourceID) { | |||
| } | |||
| } | |||
|
|
|||
| public Cache<ResourceID, T> getCache() { | |||
| return cache; | |||
| public Map<ResourceID, T> getCache() { | |||
There was a problem hiding this comment.
This will be addressed in a subsequent PR, let's merge this as-is for now.
No description provided.