Skip to content

fix: remove deprecated api #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2022
Merged

fix: remove deprecated api #842

merged 4 commits into from
Mar 18, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Jan 17, 2022

A really small PR

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csviri csviri self-assigned this Jan 17, 2022
@csviri csviri changed the base branch from main to next March 18, 2022 12:13
@metacosm
Copy link
Collaborator

We've tried this before, it has never worked and we probably should look into why

@csviri
Copy link
Collaborator Author

csviri commented Mar 18, 2022

We've tried this before, it has never worked and we probably should look into why

Fixed now, it's a strange new behavior with the client. But it's not bad, in terms that the status should be always the result of the last reconciliation.

Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 61 Code Smells

39.2% 39.2% Coverage
0.3% 0.3% Duplication

@csviri csviri merged commit 392c365 into next Mar 18, 2022
@csviri csviri deleted the remove-deprecated-api branch March 18, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants