refactor: clean up configurations #876
Conversation
metacosm
commented
Jan 27, 2022
metacosm
commented
- refactor: use DefaultResourceConfiguration for controller configuration
- feat: encapsulate Kubernetes dependent configuration
metacosm
added
the
kind/feature
| @@ -13,14 +13,13 @@ | |||
|
|
|||
| public class KubernetesDependentResourceController<R extends HasMetadata, P extends HasMetadata> | |||
There was a problem hiding this comment.
TBH, don't see why we need this controller per resource model. Why cannot just the dependent resource manager handle this? Like having it aggregate the controllers and the configuration. But this is probably something to discuss if we decide we got his way.
There was a problem hiding this comment.
Because it needs to be passed around at the moment. This change is about putting together the informer part and the ownership configuration into a single coherent configuration. Cleans up things by showing what belongs together. Helps things with the Quarkus extension as well.
We might indeed revisit, clean things further later but this change makes sense within the current scope.
This will help for passing it around as one object instead of passing the informer configuration part and the owned status separately.
metacosm
force-pushed
the
clean-up-configs
branch
from
3b3692c to
8cca142
Compare
|
SonarCloud Quality Gate failed. |
