Temporal resource cache in Event Source #965

csviri · 2022-02-22T14:52:27Z

See two linked issues.

# Conflicts: # operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/standalonedependent/StandaloneDependentTestReconciler.java

# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

…ic. And filtering in informers by the just updated resource version

csviri · 2022-02-22T14:58:34Z

For now without tests, will add tomorrow.

...ore/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java

csviri · 2022-02-23T17:00:57Z

Will update the docs (probably together with dependent resources docs).

# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java # operator-framework/src/main/java/io/javaoperatorsdk/operator/config/runtime/AnnotationControllerConfiguration.java # operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/standalonedependent/StandaloneDependentTestReconciler.java

.../src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/EventBuffer.java

...n/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

...java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporalResourceCache.java

...io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java

...n/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

metacosm · 2022-02-24T15:03:09Z

...n/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

+        return;
+      }
+      if (temporalCacheHasResourceWithVersionAs(resource)) {
+        super.onAdd(resource);


Move this code outside of if/else since it's used in both branches.

there is now a different log message, so hmm not sure...

I meant the super.onAdd(resource): it could be put outside of the if/else since it's done anyway.

…tor/processing/event/source/informer/ManagedInformerEventSource.java Co-authored-by: Chris Laprun <[email protected]>

metacosm · 2022-02-24T17:41:54Z

...n/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

+          "Skipping event propagation for {}, since was a result of a reconcile action. Resource ID: {}",
+          operation,
+          ResourceID.fromResource(newObject));
+      superOnOp.run();


superOnOp is run in both branches so could be run outside of the if/else. No big deal either way. :)

metacosm

I don't have a good grasp of how things are supposed to work right now so trusting you on this! 😄
Let's merge and see how it goes with use.

sonarqubecloud · 2022-02-25T10:03:47Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
31 Code Smells

39.4% Coverage
0.4% Duplication

csviri added 14 commits February 17, 2022 10:25

feat: up to date resource from get resource

1cb3457

feature: populate change to informer after latest update

5ecfe4b

fix: sample change

cdd91b3

fix: integration tests

b501d19

fix: temporal cache for reading resources after update

f53b46e

docs: temporal cache

58d52cd

fix: remove not used method

71e54df

fix: unit test for temp cache

d0033fa

fix: unit test wip

40e4063

fix: unit test dependent resource

38fbed8

fix: format

bf71615

Merge branch 'next' into dr-up-to-date-get-resource

2dbdbf3

# Conflicts: # operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/standalonedependent/StandaloneDependentTestReconciler.java

Merge branch 'next' into dr-up-to-date-get-resource

9d31856

# Conflicts: # operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java

feature: Handling just updated resources in informers and related log…

ec2a72c

…ic. And filtering in informers by the just updated resource version

csviri self-assigned this Feb 22, 2022

This was linked to issues Feb 22, 2022

Always return the up to date resource by getResource(primary) after create or update in K8S Dependent Resources #924

Closed

Filtering Event of Informers After Watched Resource Update #870

Closed

metacosm reviewed Feb 22, 2022

View reviewed changes

...ore/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java Outdated Show resolved Hide resolved

csviri added 2 commits February 23, 2022 10:58

fix: remove feature flag for informer event filter

6e3c5ed

fix: unit and integration tests

b4286bf

csviri marked this pull request as ready for review February 23, 2022 15:26

csviri requested a review from metacosm February 23, 2022 15:26

csviri added 2 commits February 23, 2022 17:14

fix: logging

49f008c

fix: loggings

26e14d5

csviri mentioned this pull request Feb 23, 2022

Update resource cache after update/create from Dependent Resource #953

Closed

fix: test condition

e6a0aa8

csviri added 2 commits February 23, 2022 22:38

fix: bulletproof resource version filter

73afe1e

fix: recording wip

a39dc1c

csviri added 9 commits February 24, 2022 10:18

fix: algorithm for event syncing

b2910a3

docs: explanation

c176c7f

fix: format

3d13950

fix: dependent resource integration

87c6b20

fix: build fix merged next

30d8cd8

fix: dependent support resource update

56bbe97

fix: integration test

253c805

docs: wip

abc15f4

metacosm reviewed Feb 24, 2022

View reviewed changes

csviri and others added 3 commits February 24, 2022 17:00

Update operator-framework-core/src/main/java/io/javaoperatorsdk/opera…

1fade82

…tor/processing/event/source/informer/ManagedInformerEventSource.java Co-authored-by: Chris Laprun <[email protected]>

fix: format, some fixes from review

2c6e1be

fix: fixes for CR

a65d24e

metacosm reviewed Feb 24, 2022

View reviewed changes

metacosm approved these changes Feb 24, 2022

View reviewed changes

fix: naming and unit tests

51e6494

csviri merged commit 844323f into next Feb 25, 2022

csviri deleted the temporal-resource-cache-in-eventsource branch February 25, 2022 10:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Temporal resource cache in Event Source #965

Temporal resource cache in Event Source #965

Uh oh!

csviri commented Feb 22, 2022 •

edited

Loading

Uh oh!

csviri commented Feb 22, 2022

Uh oh!

Uh oh!

csviri commented Feb 23, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metacosm Feb 24, 2022

Uh oh!

csviri Feb 24, 2022

Uh oh!

metacosm Feb 24, 2022

Uh oh!

metacosm Feb 24, 2022

Uh oh!

metacosm left a comment

Uh oh!

sonarqubecloud bot commented Feb 25, 2022

Uh oh!

Uh oh!

Temporal resource cache in Event Source #965

Temporal resource cache in Event Source #965

Uh oh!

Conversation

csviri commented Feb 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

csviri commented Feb 22, 2022

Uh oh!

Uh oh!

csviri commented Feb 23, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metacosm Feb 24, 2022

Choose a reason for hiding this comment

Uh oh!

csviri Feb 24, 2022

Choose a reason for hiding this comment

Uh oh!

metacosm Feb 24, 2022

Choose a reason for hiding this comment

Uh oh!

metacosm Feb 24, 2022

Choose a reason for hiding this comment

Uh oh!

metacosm left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 25, 2022

Uh oh!

Uh oh!

csviri commented Feb 22, 2022 •

edited

Loading