Skip to content

Refactor WebPage Sample #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 28, 2022
Merged

Refactor WebPage Sample #976

merged 6 commits into from
Feb 28, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Feb 28, 2022

Now implementation showcases standalone dependent resources and classic version. Add e2e tests later in a new PR.

@csviri csviri self-assigned this Feb 28, 2022
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we also use the "classic" mode in the tests?

@csviri
Copy link
Collaborator Author

csviri commented Feb 28, 2022

LGTM. Should we also use the "classic" mode in the tests?

The plan is to use both, in E2E tests (so 2 tests). Not sure yet how. Bit will manage it somehow.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 31 Code Smells

35.2% 35.2% Coverage
0.4% 0.4% Duplication

@csviri csviri merged commit 019771f into next Feb 28, 2022
@csviri csviri deleted the refactor-samples branch February 28, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare WebPage sample variants with low level API and the Dependent Resources
2 participants