Skip to content

feat: matcher avoiding creating the desired state when possible #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2022
Merged

feat: matcher avoiding creating the desired state when possible #992

merged 2 commits into from
Mar 4, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Mar 2, 2022

Fixes #986

@metacosm metacosm self-assigned this Mar 2, 2022
@metacosm metacosm requested a review from csviri March 2, 2022 15:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 36 Code Smells

36.9% 36.9% Coverage
0.3% 0.3% Duplication

@metacosm metacosm marked this pull request as ready for review March 3, 2022 15:01
@csviri csviri linked an issue Mar 4, 2022 that may be closed by this pull request
Consider a simpler Matcher interface #986
Closed
csviri
csviri approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a more generic approach.

Maybe will add some generic updater with desired only matcher as utility as separate PR, but otherwise really great!

@csviri csviri merged commit 9d269a6 into next Mar 4, 2022
@csviri csviri deleted the alternative-matcher branch March 4, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider a simpler Matcher interface
2 participants
@metacosm @csviri