Skip to content

Subscription Conditions should be set to false, instead of being removed. #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anik120 opened this issue Feb 5, 2024 · 1 comment
Open
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@anik120
Copy link
Contributor

anik120 commented Feb 5, 2024

Feature Request

Is your feature request related to a problem? Please describe.

According to upstream API conventions, conditions on a CR should be set to true/false, and not removed. Some of the conditions for the subscription CR were being removed, while some were following the upstream convention. This confusion led to bugs in turn. See #3170 (comment)

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties

Controllers should apply their conditions to a resource the first time they visit the resource, even if the status is Unknown. This allows other components in the system to know that the condition exists and the controller is making progress on reconciling that resource.

Not all controllers will observe the previous advice about reporting "Unknown" or "False" values. For known conditions, the absence of a condition status should be interpreted the same as Unknown, and typically indicates that reconciliation has not yet finished (or that the resource state may not yet be observable).

Describe the solution you'd like

Set all conditions to the correct state once resolution is successful, in a consistent manner for all conditions.

@anik120 anik120 added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 5, 2024
Copy link

github-actions bot commented Jun 2, 2025

Issues go stale after 90 days of inactivity. If there is no further activity, the issue will be closed in another 30 days.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant