Subscription Conditions should be set to false, instead of being removed. #3171
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
lifecycle/stale
Denotes an issue or PR has remained open with no activity and has become stale.
Feature Request
Is your feature request related to a problem? Please describe.
According to upstream API conventions, conditions on a CR should be set to true/false, and not removed. Some of the conditions for the subscription CR were being removed, while some were following the upstream convention. This confusion led to bugs in turn. See #3170 (comment)
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties
Describe the solution you'd like
Set all conditions to the correct state once resolution is successful, in a consistent manner for all conditions.
The text was updated successfully, but these errors were encountered: