-
Notifications
You must be signed in to change notification settings - Fork 560
Fix e2e test matrix #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix e2e test matrix #3445
Conversation
a8ea297
to
0a0cd4d
Compare
d76ccad
to
691f677
Compare
69dc03c
to
f315747
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
f315747
to
5c0e1ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @perdasilva,
I understand that we are working on breaking the tests into chunks. The code looks good to me; I didn’t spot any issues
-
Validation via Logs:
- I reviewed the logs from a previous PR before the change (GitHub Actions Run).
- Observations from the previous logs:
-
Post-Change Behavior:
- After the change, the same test is now executed only in chunk 3.
- Based on this, it seems the change is working as intended.
However, since I’m not familiar with it yet, you might want input from others before merging. But, from my perspective, the change seems to be doing what it’s intended to do, so LGTM
Signed-off-by: Per Goncalves da Silva <[email protected]>
Pull Request is not mergeable
Description of the change:
I've noticed the e2e test matrix is off. The last test chunk is running all tests.
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue