Skip to content

Fix e2e test matrix #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

perdasilva
Copy link
Collaborator

Description of the change:
I've noticed the e2e test matrix is off. The last test chunk is running all tests.

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@perdasilva perdasilva changed the title [WIP] Fix e2e test matrix Fix e2e test matrix Nov 19, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@perdasilva perdasilva changed the title Fix e2e test matrix [WIP] Fix e2e test matrix Nov 19, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@perdasilva perdasilva force-pushed the perdasilva/fix-e2e branch 4 times, most recently from 69dc03c to f315747 Compare November 20, 2024 12:03
Per Goncalves da Silva added 3 commits November 20, 2024 14:06
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva changed the title [WIP] Fix e2e test matrix Fix e2e test matrix Nov 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2024
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @perdasilva,

I understand that we are working on breaking the tests into chunks. The code looks good to me; I didn’t spot any issues

  • Validation via Logs:

    • I reviewed the logs from a previous PR before the change (GitHub Actions Run).
    • Observations from the previous logs:
      • The test operator with dependencies from different CatalogSources with priorities was executed in both chunk 2 and chunk 3.

      • See the attached image for how I reviewed this:

        Screenshot 2024-11-25 at 10 42 51

  • Post-Change Behavior:

    • After the change, the same test is now executed only in chunk 3.
    • Based on this, it seems the change is working as intended.

However, since I’m not familiar with it yet, you might want input from others before merging. But, from my perspective, the change seems to be doing what it’s intended to do, so LGTM

@perdasilva perdasilva enabled auto-merge November 25, 2024 11:00
Signed-off-by: Per Goncalves da Silva <[email protected]>
auto-merge was automatically disabled November 25, 2024 15:46

Pull Request is not mergeable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants