🐛 fix(olm): improve error logging for missing olm.managed label #3558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentito
reviewed
Apr 24, 2025
camilamacedo86
force-pushed
the
fix-message-error
branch
from
31d72cc to
adc32e6
Compare
bentito
reviewed
Apr 24, 2025
Previously, nonconforming CRDs (missing the label) were logged as INFO, but this caused the to enter a CrashLoopBackOff state due to unhandled inconsistencies. This commit raises the log level to and enhances the message with actionable advice, clarifying that users should either delete CRDs for uninstalled solutions or label them appropriately. The root cause of the scenario is: From an old release (ocp 4.15) the component managed by OLM should have the label olm.managed: true added to comply with the new checks.
camilamacedo86
force-pushed
the
fix-message-error
branch
from
dacb6a6 to
24a34a9
Compare
camilamacedo86
commented
Apr 27, 2025
There was a problem hiding this comment.
Since you preferred not to include the suggestion on how to fix the scenario, that part has been removed. However, just a few points to highlight:
- The information about the GVR is already present
- We should not remove the phrase "found nonconforming items", as that is essential for users to find the related KCS article and resolve the issue: KCS 7112019.
With these adjustments, I hope we can move forward with this small fix.
Could you please let me know if it has your LGTM/approval?
Thank you very much for your help and collaboration!
|
/lgtm |
perdasilva
approved these changes
Apr 28, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
Previously, nonconforming CRDs (missing the label) were logged as INFO, but this caused the to enter a CrashLoopBackOff state due to unhandled inconsistencies. This commit raises the log level to and enhances the message with actionable advice, clarifying that users should either delete CRDs for uninstalled solutions or label them appropriately. The root cause of the scenario is: From an old release (ocp 4.15) the component managed by OLM should have the label olm.managed: true added to comply with the new checks.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
operator-framework:master
with commit Apr 28, 2025
1d9eafd
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, nonconforming CRDs (missing the label) were logged as INFO, but this caused the to enter a CrashLoopBackOff state due to unhandled inconsistencies.
This commit raises the log level to and enhances the message with actionable advice, clarifying that users should either delete CRDs for uninstalled solutions or label them appropriately.
The root cause of the scenario is: From an old release (ocp 4.15) the component managed by OLM should have the label olm.managed: true added to comply with the new checks.