Skip to content

🐛 Remove path requirement from go-verdiff gha #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

Because the go-verdiff is required by branch protection, when it's not triggered (i.e. when a PR doesn't changed the listed paths), the PR will be unmergeable because GitHub will wait for a signal from the job and timeout (because it never runs).

Here we remove the path selector for the go-verdiff gha

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from camilamacedo86 and dtfranz May 14, 2025 15:20
@perdasilva perdasilva merged commit cef3d24 into operator-framework:master May 14, 2025
12 checks passed
perdasilva added a commit to anik120/operator-lifecycle-manager that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant