Skip to content

🐛 Add kube-apiserver egress to config map catalog source network policy #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

🐛 Add kube-apiserver egress to config map catalog source network policy #3582

merged 1 commit into from
May 19, 2025

Conversation

perdasilva
Copy link
Collaborator

Description of the change:

Adds kube-apiserver egress rule to config map backed catalog sources

Motivation for the change:

Architectural changes:

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot requested review from camilamacedo86 and oceanc80 May 19, 2025 18:54
@perdasilva perdasilva changed the title 🐛 Adds kube-apiserver egress to config map catalog source network policy 🐛 Add kube-apiserver egress to config map catalog source network policy May 19, 2025
joelanford
joelanford previously approved these changes May 19, 2025
View reviewed changes
@joelanford joelanford enabled auto-merge May 19, 2025 18:59
@joelanford joelanford added this pull request to the merge queue May 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 19, 2025
camilamacedo86
camilamacedo86 requested changes May 19, 2025
View reviewed changes
@perdasilva perdasilva force-pushed the fix-configmap-catalog branch from 6723eb3 to e745cfb Compare May 19, 2025 19:58
@perdasilva perdasilva enabled auto-merge May 19, 2025 19:59
@perdasilva perdasilva requested a review from camilamacedo86 May 19, 2025 19:59
camilamacedo86
camilamacedo86 approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the mocks we might need the UID ( lest see if pass all fine )

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2025
@perdasilva perdasilva added this pull request to the merge queue May 19, 2025
Merged via the queue into operator-framework:master with commit 8c53b7f May 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@joelanford joelanford joelanford left review comments

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

@camilamacedo86 camilamacedo86

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perdasilva @joelanford @camilamacedo86