Bug 1915905: Preserve custom catsrc w/ default catsrc name #375
Conversation
In operator-framework#362, marketplace's catalogsource reconciler was updated to allow custom Catalogsources with the same name as one of the default Catalogsources, when the default Catalogsource was disabled first with the operatorhub api. However, when marketplace was restarted, the custom catalogsource was being force deleted by marketplace's operatorhub controller. This PR adds a special annotation to the default CatalogSources, and updates the operator to delete any catalogsource with the same name as one of the default only if the CatalogSource has that special annotation. In addition, the behavior of the marketplace operator as it relates to reconciling the default CatalogSources should no longer be tied to its process lifecycle.
|
@benluddy: This pull request references Bugzilla bug 1915905, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-urgent
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@benluddy: This pull request references Bugzilla bug 1915905, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/lgtm |
|
/bugzilla refresh |
|
@benluddy: This pull request references Bugzilla bug 1915905, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-aws-operator Filed #376 to track the flaky end-to-end test. |
|
/test e2e-aws-serial |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@operator-framework/patch-managers PTAL |
crawford
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@benluddy: All pull requests linked via external trackers have merged: Bugzilla bug 1915905 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In #362, marketplace's catalogsource reconciler was updated to allow
custom Catalogsources with the same name as one of the default
Catalogsources, when the default Catalogsource was disabled first with
the operatorhub api. However, when marketplace was restarted, the
custom catalogsource was being force deleted by marketplace's
operatorhub controller.
This PR adds a special annotation to the default CatalogSources, and
updates the operator to delete any catalogsource with the same name as
one of the default only if the CatalogSource has that special
annotation. In addition, the behavior of the marketplace operator as
it relates to reconciling the default CatalogSources should no longer
be tied to its process lifecycle.