-
Notifications
You must be signed in to change notification settings - Fork 27
feat(ForcedDecisions): adding SetForcedDecision support in decide api. #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
properties: | ||
flagKey: | ||
type: string | ||
ruleKey: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please check if this accepts optional as well.
@@ -12,7 +12,7 @@ require ( | |||
github.com/go-kit/kit v0.9.0 | |||
github.com/google/uuid v1.1.1 | |||
github.com/lestrrat-go/jwx v0.9.0 | |||
github.com/optimizely/go-sdk v1.7.0 | |||
github.com/optimizely/go-sdk v1.7.1-0.20211102215133-82644c6670e8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump the correct version once go-sdk is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a type name change suggested
api/openapi-spec/openapi.yaml
Outdated
required: | ||
- userId | ||
OptimizelyForcedDecision: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the name? We have other public definition of OptimizelyForcedDecision and it can be confusing.
Just "ForcedDecision"?
pkg/handlers/decide.go
Outdated
} | ||
|
||
// OptimizelyForcedDecision defines Forced Decision | ||
type OptimizelyForcedDecision struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here. Change to "ForcedDecision"?
Summary
Added SetForcedDecision support in decide api.
Test plan