Skip to content

feat(forced-decision): Adding acceptance tests for forced-decision. #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 1, 2021

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Nov 24, 2021

Summary

  • Adding acceptance tests for forced-decision parameters in decide-api.

@yasirfolio3 yasirfolio3 reopened this Nov 25, 2021
@msohailhussain msohailhussain requested a review from a team November 29, 2021 20:06
@@ -214,4 +293,4 @@ def test_decide_403(session_override_sdk_key):
assert resp.json()['error'] == 'unable to fetch fresh datafile (consider ' \
'rechecking SDK key), status code: 403 Forbidden'

resp.raise_for_status()
resp.raise_for_status()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new empty line

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yasirfolio3 yasirfolio3 requested a review from Mat001 November 30, 2021 10:10
"forcedDecisions": [
{
"flagKey": forced_flag,
"ruleKey": "{}".format(forced_rule),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use f-string notation here? We're not using Py 2 in acceptance tests, thank god :-)
So if you just do "ruleKey": f"{forced_rule}"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msohailhussain @yasirfolio3 Feel free to merge. String formatting would be nice to update, other than that lgtm.

@Mat001 Mat001 merged commit e53c190 into master Dec 1, 2021
@Mat001 Mat001 deleted the yasir/forced-decision-acceptance branch December 1, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants