-
Notifications
You must be signed in to change notification settings - Fork 27
feat(forced-decision): Adding acceptance tests for forced-decision. #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -214,4 +293,4 @@ def test_decide_403(session_override_sdk_key): | |||
assert resp.json()['error'] == 'unable to fetch fresh datafile (consider ' \ | |||
'rechecking SDK key), status code: 403 Forbidden' | |||
|
|||
resp.raise_for_status() | |||
resp.raise_for_status() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a new empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
"forcedDecisions": [ | ||
{ | ||
"flagKey": forced_flag, | ||
"ruleKey": "{}".format(forced_rule), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use f-string notation here? We're not using Py 2 in acceptance tests, thank god :-)
So if you just do "ruleKey": f"{forced_rule}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msohailhussain @yasirfolio3 Feel free to merge. String formatting would be nice to update, other than that lgtm.
Summary