-
Notifications
You must be signed in to change notification settings - Fork 27
[FSSDK-8707] feat(metrics): Adds support for prometheus #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prisma Cloud has found errors in this PR ⬇️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Not an expert on Prometheus. A few license year comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Not an expert on Prometheus. A few license year comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good now
* Added support for prometheus. * Added unit tests. * Added unit tests. * updated headers. * fixes. * cleanup. * Adding support for labels in prometheus and expvar. * Refactor code * fix readme * Fix copyright year --------- Co-authored-by: Mirza Sohail Hussain <[email protected]> Co-authored-by: Pulak Bhowmick <[email protected]>
Summary
OPTIMIZELY_ADMIN_METRICSTYPE
env variable can be used to switch betweenexpvar
andprometheus
. Default value isexpvar
.Tests