Skip to content

[FSSDK-8707] feat(metrics): Adds support for prometheus #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 6, 2023

Conversation

yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Dec 8, 2022

Summary

  • Adds support for prometheus in metrics. OPTIMIZELY_ADMIN_METRICSTYPE env variable can be used to switch between expvar and prometheus. Default value is expvar.

Tests

  • Added unit tests.
  • All previous tests should pass.

@yasirfolio3 yasirfolio3 changed the title feat(metrics): Added support for prometheus feat(metrics): Adds support for prometheus Dec 9, 2022
@russell-loube-optimizely russell-loube-optimizely changed the title feat(metrics): Adds support for prometheus [FSSDK-8707] feat(metrics): Adds support for prometheus May 30, 2023
Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

@pulak-opti pulak-opti marked this pull request as ready for review June 2, 2023 18:16
@pulak-opti pulak-opti requested review from Mat001 and jaeopt June 2, 2023 18:24
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not an expert on Prometheus. A few license year comments

Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not an expert on Prometheus. A few license year comments

@pulak-opti pulak-opti requested a review from Mat001 June 5, 2023 17:32
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good now

@pulak-opti pulak-opti merged commit bd0039f into master Jun 6, 2023
@pulak-opti pulak-opti deleted the yasir/prometheus branch June 6, 2023 14:03
pulak-opti added a commit that referenced this pull request Nov 2, 2023
* Added support for prometheus.

* Added unit tests.

* Added unit tests.

* updated headers.

* fixes.

* cleanup.

* Adding support for labels in prometheus and expvar.

* Refactor code

* fix readme

* Fix copyright year

---------

Co-authored-by: Mirza Sohail Hussain <[email protected]>
Co-authored-by: Pulak Bhowmick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants