Skip to content

Add bower support #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2015
Merged

Add bower support #135

merged 1 commit into from
Jul 27, 2015

Conversation

kamui
Copy link
Contributor

@kamui kamui commented Jul 27, 2015

We want to use nuclear.js in a Rails app, but currently we're using rails-assets.org to pull in and manage javascript module dependencies. rails-assets.org works by wrapping bower modules, so I'm submitting this PR to add a bower.json config file to the project so it'll be available in bower and thus available in rails-assets.org. Thanks!

@kamui kamui changed the title Add bower.json support Add bower support Jul 27, 2015
@jordangarcia
Copy link
Contributor

Is there anything else that needs to be done here or just the merge?

jordangarcia added a commit that referenced this pull request Jul 27, 2015
@jordangarcia jordangarcia merged commit 1a17333 into optimizely:master Jul 27, 2015
@kamui
Copy link
Contributor Author

kamui commented Jul 27, 2015

I think just the merge, I already registered the module with your git repo. So you own the registered module on bower.io.

Oh, I think you'll have to issue a new release, with a git tag. It keeps trying to checkout 1.1.0 which is missing a bower.json file.

@jordangarcia
Copy link
Contributor

@kamui try now with 1.1.1 tag

@kamui kamui deleted the bower branch July 27, 2015 21:40
@kamui
Copy link
Contributor Author

kamui commented Jul 27, 2015

@bhamodi
Copy link
Contributor

bhamodi commented Jul 27, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants