Skip to content

Add Neo4j-Java-Driver to library-and-framework-list.json. #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

michael-simons
Copy link
Contributor

@michael-simons michael-simons commented Dec 23, 2022

What does this PR do?

This adds the Neo4j-Java-Driver to the list of tested libraries and frameworks.
We use the linked repository in CI, testing all currently maintained versions of the driver.

Checklist before merging

  • I have properly formatted metadata files (see CONTRIBUTING document)
  • I have added thorough tests. (see this)

@fniephaus fniephaus self-requested a review December 23, 2022 21:32
@fniephaus
Copy link
Member

Thanks a lot for the PR, @michael-simons! Do these neo4j-java-driver-native-smoke-tests run regularly on some CI system? If so, it'd be great if you could add a link to the tests_locations.

@michael-simons
Copy link
Contributor Author

My pleasure and indeed they do. @injectives do you if we can publish the result to the repo or the main driver repo?

@fniephaus
Copy link
Member

@michael-simons any update on this? We're soon going to publish a list based on this JSON file and I'd like to merge this asap. I'm happy to merge this now if we flag the library as community-tested, or fully-tested if you provide an appropriate test location.

@michael-simons
Copy link
Contributor Author

Hej.

You see the test results on each PR to the official driver repo, i.e.

neo4j/neo4j-java-driver#1352

image

Stuff is hidden behind the details button going with the merge commit…

This is fully tested and the addition to the list is not really different than let's say the Helidon ones.

@fniephaus fniephaus merged commit 462a3e6 into oracle:master Jan 9, 2023
@fniephaus
Copy link
Member

Thanks for clarifying, @michael-simons!

@michael-simons
Copy link
Contributor Author

My pleasure and thanks for including us!

@michael-simons michael-simons deleted the neo4j-java-driver branch January 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants