GitHub Community
Stop hiding conversations in PRs #130618
Replies: 9 comments 11 replies
-
|
💯% agree! |
Beta Was this translation helpful? Give feedback.
-
|
200% agree |
Beta Was this translation helpful? Give feedback.
-
|
At the very least, if conversations must be hidden, hide the resolved one so we can see what unresolved issues remain. |
Beta Was this translation helpful? Give feedback.
-
|
This appears to duplicate https://github.com/orgs/community/discussions/112603. |
Beta Was this translation helpful? Give feedback.
-
|
It is also a (near-)duplicate of https://github.com/orgs/community/discussions/11842 from 2022 (albeit with a more actionable title). And https://github.com/orgs/community/discussions/75820 proposes GitHub work around the problem by showing the number of unresolved items in the "hidden" message. Upvotes all around. (I've started adding instructions to "please search this page for 'hidden conversations'" in every code review. 😬 ) |
Beta Was this translation helpful? Give feedback.
-
Same here. |
Beta Was this translation helpful? Give feedback.
-
|
And there's https://github.com/orgs/community/discussions/7638 as well... seems to be a popular/frequent complaint. |
Beta Was this translation helpful? Give feedback.
-
|
Alternately, put a button on the page to click to "Show all conversations" (or "Show all unresolved conversations") which unhides ALL of them so I don't have to click several times. (Note that it can be hard to keep track of where you are in a long sequence of them (esp. if some are resolved) because of the visual "jump" when you un-hide some.) So if you (GH devs/PMs) are convinced that the current behavior is preferred by the majority (or should be the default for some other reason), then please at least give the rest of us a one-click way to make sure we're not missing anything. Or at least add a Settings option somewhere to disable this, or to set the threshold for it. Authors of PRs I've reviewed have inadvertently merged code with active unresolved comments simply because they missed comments due to this. (And yes, it really was inadvertent.) Hiding unresolved comments seems to defeat the very purpose of review comments; I would think that unresolved comments would be considered one of the highest-priority things on the page! Can you please share the rationale for hiding them by default? |
Beta Was this translation helpful? Give feedback.
-
|
Very much agreed. I need to remind PR authors to look for the hidden conversations. If a PR author hasn't addressed a comment, then I wonder if they even saw the comment. Hiding conversations is a misfeature and we should not need to take extra steps to make them be visible. |
Beta Was this translation helpful? Give feedback.
-
|
It seems like conversations are only hidden this way in the "Conversation" tab—not in the "Files changed" tab.1 So a workaround is to always check a PR's "Files changed" comments before moving forward with a merge. Footnotes
|
Beta Was this translation helpful? Give feedback.
-
|
True, that is somewhat better than nothing, but it's very awkward to have to step through all of the conversations in a tiny popup (about 400x365, less than 1.8% of the area of a 4K display, no matter how I resize the window As others have suggested in some of the several other discussions of this problem (see below), having buttons to step to the "Previous [unresolved] conversation" and "Next [unresolved] conversation" would be another way to ease the pain here. GH Community discussion threads on this that I've happened to see links to (so there are probably more):
|
Beta Was this translation helpful? Give feedback.
-
|
Yes, this is super annoying. What makes this even extra annoying: Ideally you either completely remove this feature (maybe fold those commit notifications into "$user added $N commits" instead, if it's more than two new commits or whatever) or add two additional buttons so you have three buttons in the "hidden items" section:
where the last one adds N more of the newest replies. I'm really surprised that this was deployed to endusers in the current state and also hasn't been fixed/improved in several years (despite several threads here complaining about it). |
Beta Was this translation helpful? Give feedback.
-
|
I also find this feature disruptive. It wouldn't be that bad if at least only resolved conversations would be hidden. I'm often facing situations when Github shows some resolved and outdated comments and hides the important ones that still need to be fixed or discussed. |
Beta Was this translation helpful? Give feedback.
-
|
I created a Chrome extension that streamlines PR reviews by hiding unnecessary timeline entries, helping you focus on what truly matters. It also reduces scrolling, making it easier to find the "Load more" button when needed. |
Beta Was this translation helpful? Give feedback.
-
|
Can you please create such extension for Firefox too?.. |
Beta Was this translation helpful? Give feedback.
-
I can try! Maybe open an issue in the repo as reminder 😉 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks in advance and here is the issue: LeleDallas/Conversation-Cleaner#2 |
Beta Was this translation helpful? Give feedback.
-
|
Adding another vote for "please stop hiding random conversations" in PRs. I'm missing important conversations that are still in progress because GitHub decided to hide them for some reason. |
Beta Was this translation helpful? Give feedback.
-
|
Agree, this is very annoying. I can't directly CTRL+F something, and have to instead scroll until I find the button, click it and then CTRL+F something. Just add a toggle on settings to disable this. |
Beta Was this translation helpful? Give feedback.
-
|
I've built and updated a chrome extension that include an "Expand All" button in the popup. It will automatically click all "Load more…" buttons so you can quickly reveal all content and use Ctrl+F without scrolling manually |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Select Topic Area
Product Feedback
Body
This very strange pattern at GitHub pull requests is disrupting smooth reviews between members of my team. This marker is easily missed and leading developers to re-submit review requests before having addressed all concerns.
Please remove this 'feature' so that we're sure that our feedback is seen by our peers.
Note: This is not about the amount of messages in a thread. This is about individual comments on code being hidden once they're over 10 or so.
Beta Was this translation helpful? Give feedback.
All reactions