-
-
Notifications
You must be signed in to change notification settings - Fork 33
Improve serialization of VFS URL query parameters #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0701f30
Fix unused options in readdir system VFS adapter
mahsashadi 12a3178
Improve serialization of VFS URL query parameters
mahsashadi 8643d31
Export encodeQueryData and add fetch tests
e89d5f9
Solve the preservation of types in encodeQueryData
9f62a30
Fixes null type in typesToken
14615e5
Ignore vfs client options from being send to the server
a5e92a1
Preserving the options passed into filterOptions method
98534cb
vfs capabilities method is added
6a3c84d
merge conflict resolved.
4bd37c9
remove unnecessary console.log
64ff0c3
each mountpoint capability is cached in vfs abstraction
68aa1d5
Ascii based sort function is added, and transformReaddir tests are fixed
e577c02
Merge branch 'os-js:master' into patch-2
mahsashadi 12d5b65
Support serialization of URL query parameters
2f534f5
Merge branch 'os-js:master' into patch-2
mahsashadi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import * as fetch from '../../src/utils/fetch'; | ||
|
||
describe('utils.fetch#encodeQueryData', () => { | ||
test('should create valid query string', () => { | ||
const result1 = fetch.encodeQueryData({ | ||
a: 1, | ||
b: true, | ||
c: null, | ||
d: 'foo', | ||
e: undefined | ||
}); | ||
|
||
const result2 = fetch.encodeQueryData({ | ||
a: 1, | ||
b: { | ||
c: { | ||
d: 'foo' | ||
} | ||
} | ||
}); | ||
|
||
expect(result1).toEqual('a=1&b=true&c=null&d=foo&e=undefined'); | ||
expect(result2).toEqual('a=1&b=%7B%22c%22%3A%7B%22d%22%3A%22foo%22%7D%7D'); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.