Skip to content

feat: Add AWS lambda support for IPV6 outbound connections in VPC #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Martijn02
Copy link

@Martijn02 Martijn02 commented Dec 23, 2024

Allows VPC-enabled Lambda functions to use an egress-only internet gateway to access the internet or other AWS services via IPv6. This eliminates the need for a NAT Gateway, reducing costs and simplifying architecture.

Note that this change is fully backwards compatible. It only adds an optional parameter to the VPC configuration.

The credits for the code change itself should go to @rvaralda who created a pull request for the original serverless project.

Allows VPC-enabled Lambda functions to use an egress-only internet gateway to access the internet or other AWS services via IPv6. This eliminates the need for a NAT Gateway, reducing costs and simplifying architecture.
The credits for the code change should go to @rvaralda who created [https://github.com/serverless/serverless/pull/12243](a pull request) for the original serverless project.
@mnapoli
Copy link
Contributor

mnapoli commented Dec 23, 2024

Thanks!

@mnapoli mnapoli merged commit 316f966 into oss-serverless:main Dec 23, 2024
@mnapoli
Copy link
Contributor

mnapoli commented Dec 23, 2024

Doh I got bit by the new GitHub pull request UI I think… They don't display clearly that the CI did not run (already reported it at https://github.com/orgs/community/discussions/143787?sort=top)… So I merged thinking the CI was green, but actually tests are failing.

I will revert this PR and re-release.

@GrahamCampbell
Copy link
Contributor

I don't think it's a UI issue, it's a CI config issue.

@GrahamCampbell
Copy link
Contributor

Oh, it was the first PR restrictions that stopped the CI running.

@mnapoli
Copy link
Contributor

mnapoli commented Dec 23, 2024

Yeah, I can't find the exact link again but essentially the new "merge experience" is green and is much much less obvious that the CI is waiting for approval before running. Makes you think the build passed.

I disabled that new UI but somehow it turned back on. Disabled it again, it's not the first time I make this mistake.

@Martijn02
Copy link
Author

I don't quite understand what's happening with this. Is there anything I can or should do to help this along?

@mnapoli
Copy link
Contributor

mnapoli commented Dec 23, 2024

I've had to revert the PR because it broke the tests on master: https://github.com/oss-serverless/serverless/actions/runs/12465150115/job/34790457936

The next step would be to reopen the PR again with working tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants