Improve the docs for using GCP to clarify the project-ID and fix a broken command. #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add some detail on what the expected project-id is? I tried using my own project but still get an error. $ gcloud auth login --project=pnacht-criticality-scorecard --update-adc
Your browser has been opened to visit:
https://accounts.google.com/o/oauth2/auth?...
Application default credentials (ADC) were updated.
You are now logged in as [pnacht@...].
Your current project is [pnacht-criticality-scorecard]. You can change this setting by running:
$ gcloud config set project PROJECT_ID
Updates are available for some Google Cloud CLI components. To install them,
please run:
$ gcloud components update
$ criticality_score github.com/kubernetes/kubernetes
2022-12-28 10:34:15.057 INFO Preparing default scorer
2022-12-28 10:34:15.058 ERROR Failed to create collector {"error": "init deps.dev source: unable to detect projectID, please refer to docs for DetectProjectID"}
main.main
/Users/pnacht/go/pkg/mod/github.com/ossf/[email protected]/cmd/criticality_score/main.go:160
runtime.main
/usr/local/go/src/runtime/proc.go:250 |
Hi @pnacht did you get any solution for this? |
oliverchang
previously approved these changes
Apr 4, 2023
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
|
@oliverchang @pnacht Please take another look. I set up an empty container to test this from scratch, and have updated the docs to hopefully make it clearer. Unfortunately there are scenarios where the auto-detect of projectID fails, so it has to be manually specified. |
oliverchang
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #289
Signed-off-by: Caleb Brown [email protected]