Add support for FORBIDDEN GraphQL responses and simplify errors. #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing.
Handle {type: "FORBIDDEN"} GitHub GraphQL error responses that are returned
when the App based authentication fails to access a repository due to
GitHub org restrictions.
Go 1.21 now supports wrapping multiple errors. This change makes use of
that feature some more too.
Signed-off-by: Caleb Brown <[email protected]>
Signed-off-by: Caleb Brown <[email protected]>
calebbrown
changed the title
maxfisher-g
approved these changes
Feb 2, 2024
calebbrown
added a commit
that referenced
this pull request
Feb 14, 2024
* Add support for FORBIDDEN GraphQL responses and use multi error wrapping.
Handle {type: "FORBIDDEN"} GitHub GraphQL error responses that are returned
when the App based authentication fails to access a repository due to
GitHub org restrictions.
Go 1.21 now supports wrapping multiple errors. This change makes use of
that feature some more too.
Signed-off-by: Caleb Brown <[email protected]>
* Remove multi-wrapped errors because we're on Go 1.19.
Signed-off-by: Caleb Brown <[email protected]>
---------
Signed-off-by: Caleb Brown <[email protected]>
calebbrown
added a commit
that referenced
this pull request
Feb 14, 2024
* Bump Go version to 1.21. - update go.mod, go.work files - update workflows - replace exp slices for std lib Signed-off-by: Caleb Brown <[email protected]> * Add support for FORBIDDEN GraphQL responses and simplify errors. (#533) * Add support for FORBIDDEN GraphQL responses and use multi error wrapping. Handle {type: "FORBIDDEN"} GitHub GraphQL error responses that are returned when the App based authentication fails to access a repository due to GitHub org restrictions. Go 1.21 now supports wrapping multiple errors. This change makes use of that feature some more too. Signed-off-by: Caleb Brown <[email protected]> * Remove multi-wrapped errors because we're on Go 1.19. Signed-off-by: Caleb Brown <[email protected]> --------- Signed-off-by: Caleb Brown <[email protected]> * Bump Dockerfile versions to 1.21.7. Signed-off-by: Caleb Brown <[email protected]> * Add version tag to docker images. Signed-off-by: Caleb Brown <[email protected]> --------- Signed-off-by: Caleb Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle {type: "FORBIDDEN"} GitHub GraphQL error responses that are returned when the App based authentication fails to access a repository due to GitHub org restrictions.
This change also simplifies some of the error handling, especially with multi-wrapped errors available in later versions of Go.