Skip to content

tls client 'session' event #20197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

tls client 'session' event #20197

wants to merge 12 commits into from

Conversation

pfgithub
Copy link
Contributor

@pfgithub pfgithub commented Jun 5, 2025

What does this PR do?

Implements the 'session' event for tls

TODO:

  • We shouldn't bother with serializing the session and sending it to JS unless listenerCount('session') > 0. Can this be checked from zig?
  • The test passes despite 'secureProtocol' being ignored, and if secureProtocol is not specified in node, it never emits 'session'. So something is wrong.

@robobun
Copy link

robobun commented Jun 5, 2025

Updated 9:34 PM PT - Jun 23rd, 2025

@pfgithub, your commit 9350959 has 4 failures in Build #19171:


🧪   To try this PR locally:

bunx bun-pr 20197

That installs a local version of the PR into your bun-20197 executable, so you can run:

bun-20197 --bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants