Skip to content

Fix Deprecation warning for PHP 8.2 #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 17, 2023
Merged

Fix Deprecation warning for PHP 8.2 #1126

merged 4 commits into from
Jul 17, 2023

Conversation

aviator-ua
Copy link

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets
License MIT

Fix Deprecation warnings for PHP 8.2

@aviator-ua aviator-ua mentioned this pull request Jul 14, 2023
Closed
@Vincz
Copy link
Collaborator

Vincz commented Jul 17, 2023

Hey @aviator-ua
Tests are breaking because of the profile.
Would you mind to update your PR with the profiler fix from here: e630664#diff-63d69b023b2cc52ebd4f6007144f0146988d1c136b2be997b746707bb098087e
It should fix the tests and I'll merge it after that.
Thanks

Vincz
Vincz reviewed Jul 17, 2023
View reviewed changes
src/Controller/ProfilerController.php
@@ -52,6 +53,10 @@ public function __invoke(Request $request, string $token): Response
$this->profiler->disable();

$profile = $this->profiler->loadProfile($token);
// Type hint as int for the $limit argument of the find method was updated in Symfony 5.4.22 and 6.2.8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aviator-ua.
Just add a @phpstan-ignore-line above line 57 and we can merge.
Thanks!

@Vincz Vincz merged commit e1facd3 into overblog:0.15 Jul 17, 2023
@Vincz
Copy link
Collaborator

Vincz commented Jul 17, 2023

Thx @aviator-ua!

@aviator-ua
Copy link
Author

@Vincz Will you create a tag? Or I should use dev-0.15 in my project?

@aviator-ua aviator-ua deleted the fix-deprecation-warning branch July 17, 2023 13:37
@Vincz
Copy link
Collaborator

Vincz commented Jul 17, 2023

@aviator-ua https://github.com/overblog/GraphQLBundle/releases/tag/v0.15.3

@glye
Copy link

glye commented Aug 1, 2023 •
edited
Loading

Hi @aviator-ua & @Vincz! It looks like we need this fix in the stable branches 0.13 / 0.14, as well as 1.0.

Could the project README be outdated? It says 1.0 is a dev branch, does not mention 0.15, and says 0.13 / 0.14 are stable branches. But I notice 0.15 got this fix while 0.13 / 0.14 didn't.
Thanks!

@rooodik
Copy link

rooodik commented Sep 25, 2023

Hi @aviator-ua & @Vincz! It looks like we need this fix in the stable branches 0.13 / 0.14, as well as 1.0.

Could the project README be outdated? It says 1.0 is a dev branch, does not mention 0.15, and says 0.13 / 0.14 are stable branches. But I notice 0.15 got this fix while 0.13 / 0.14 didn't. Thanks!

The fix for 0.14 is done, @Vincz could you have a look, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vincz Vincz Vincz approved these changes

@rooodik rooodik rooodik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aviator-ua @Vincz @glye @rooodik