Optimize validator

[murtukov]

Q	A
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes

Change the way the validation rules are generated. As result the generated classes and the TypeBuilder class reduced in size.

Before

Before the change all validation rules were genereted inside the resolver closure and passed to the InputValidator:

public function __construct(ConfigProcessor $configProcessor, GraphQLServices $services)
{
    $config = [
        'name' => self::NAME,
        'fields' => fn() => [
            'linkedConstraintsValidation' => [
                'type' => Type::boolean(),
                'resolve' => function ($value, $args, $context, $info) use ($services) {
                    $validator = new InputValidator(
                        \func_get_args(),
                        $services->get('container')->get('validator'),
                        $services->get('validatorFactory'),
                        [
                            'string1' => [
                                'link' => ['App\Models\User', 'string1', 'property'],
                            ],
                            'string2' => [
                                'link' => ['App\Models\User', 'string2', 'getter'],
                            ],
                            'string3' => [
                                'link' => ['App\Models\User', 'string3', 'member'],
                            ],
                        ],
                    );
                    return $services->mutation("mutation_mock", $args, $validator);
                },
                'args' => [
                    [
                        'name' => 'string1',
                        'type' => Type::nonNull(Type::string()),
                    ],
                    [
                        'name' => 'string2',
                        'type' => Type::nonNull(Type::string()),
                    ],
                    [
                        'name' => 'string3',
                        'type' => Type::nonNull(Type::string()),
                    ],
                ],
            ],
            'cascadeValidationWithGroups' => [
                'type' => Type::boolean(),
                'resolve' => function ($value, $args, $context, $info) use ($services) {
                    $validator = new InputValidator(
                        \func_get_args(),
                        $services->get('container')->get('validator'),
                        $services->get('validatorFactory'),
                        [
                            'address' => [
                                'cascade' => [
                                    'isCollection' => false,
                                    'referenceType' => $services->getType('Address'),
                                ],
                            ],
                            'birthdate' => [
                                'cascade' => [
                                    'groups' => ['group2'],
                                    'isCollection' => false,
                                    'referenceType' => $services->getType('Birthdate'),
                                ],
                            ],
                        ],
                    );
                    return $services->mutation("mutation_mock", $args, $validator);
                },
                'args' => [
                    [
                        'name' => 'groups',
                        'type' => Type::nonNull(Type::listOf(Type::string())),
                    ],
                    [
                        'name' => 'address',
                        'type' => fn() => Type::nonNull($services->getType('Address')),
                    ],
                    [
                        'name' => 'birthdate',
                        'type' => fn() => $services->getType('Birthdate'),
                    ],
                ],
            ],
        ],
    ];

    parent::__construct($configProcessor->process($config));
}

After

Now validation rules are generated each in the corresponding entry under the args key and the resolver closure doesn't contain much logic:

public function __construct(ConfigProcessor $configProcessor, GraphQLServices $services)
{
    $config = [
        'name' => self::NAME,
        'fields' => fn() => [
            'linkedConstraintsValidation' => [
                'type' => Type::boolean(),
                'resolve' => function ($value, $args, $context, $info) use ($services) {
                    $validator = $services->createInputValidator(func_get_args());
                    return $services->mutation("mutation_mock", $args, $validator);
                },
                'args' => [
                    [
                        'name' => 'string1',
                        'type' => Type::nonNull(Type::string()),
                        'validation' => [
                            'link' => ['App\Models\User', 'string1', 'property'],
                        ],
                    ],
                    [
                        'name' => 'string2',
                        'type' => Type::nonNull(Type::string()),
                        'validation' => [
                            'link' => ['App\Models\User', 'string2', 'getter'],
                        ],
                    ],
                    [
                        'name' => 'string3',
                        'type' => Type::nonNull(Type::string()),
                        'validation' => [
                            'link' => ['App\Models\User', 'string3', 'member'],
                        ],
                    ],
                ],
            ],
            'cascadeValidationWithGroups' => [
                'type' => Type::boolean(),
                'resolve' => function ($value, $args, $context, $info) use ($services) {
                    $validator = $services->createInputValidator(func_get_args());
                    return $services->mutation("mutation_mock", $args, $validator);
                },
                'args' => [
                    [
                        'name' => 'groups',
                        'type' => Type::nonNull(Type::listOf(Type::string())),
                    ],
                    [
                        'name' => 'address',
                        'type' => fn() => Type::nonNull($services->getType('Address')),
                        'validation' => InputValidator::CASCADE,
                    ],
                    [
                        'name' => 'birthdate',
                        'type' => fn() => $services->getType('Birthdate'),
                        'validation' => [
                            InputValidator::CASCADE => ['group2'],
                        ],
                    ],
                ],
            ],
        ],
    ];

    parent::__construct($configProcessor->process($config));
}

Additionally

• The 'cascade' literal is replaced with the constant InputValidator::CASCADE
• The creation of the InputValidator instances isn't hardcoded inside the resolver closure, but fetched from a service:
  Before:

   $validator = new InputValidator(
       \func_get_args(),
       $services->get('container')->get('validator'),
       $services->get('validatorFactory'),
       [ /* property constraints */ ],
       [ /* class constraints */]
   );

  After:

  $validator = $services->createInputValidator(func_get_args());

• The keys isCollection and referenceType are removed as unnecessary, because this information is read directly from the type classes.

[mcg-web]

Also can you provide an example of generation without no validation present please?

[murtukov]

Also can you provide an example of generation without no validation present please?

If no validation is present, then types are generated as usual, so there is nothing to provide