Skip to content

Forward compatibility with symfony 6 at Parser #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

edefimov
Copy link
Contributor

Q A
Bug fix? maybe
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets #...
License MIT

Starting since symfony 5.2 accessing non-scalar parameters via $request->query->get() is deprecated and will throw an exception in symfony 6. This PR fixes deprecation warning and provides forward compatibility with symfony 6

@mcg-web
Copy link
Member

mcg-web commented Apr 29, 2021

Thank you @edefimov ! Sorry for the late review !

@mcg-web mcg-web merged commit 76d9443 into overblog:0.13 Apr 29, 2021
@edefimov
Copy link
Contributor Author

edefimov commented Dec 2, 2021

@mcg-web , is it possible to issue a bug-fix tag with this PR merged?

@edefimov edefimov deleted the fix-symfony-5.2-deprecation branch December 2, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants