Skip to content

Update mongo seed 6 #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update mongo seed 6 #270

merged 1 commit into from
Jul 17, 2024

Conversation

mserranom
Copy link
Contributor

Description

Update config-seed to Mongo v6, splitting image and version.

Contributor Agreement

@mserranom mserranom force-pushed the msm-update-mongo-seed-6 branch from faf4cb8 to dc7c155 Compare July 17, 2024 09:41
@mserranom mserranom requested a review from mlevans0 July 17, 2024 09:41
Copy link
Member

@das7pad das7pad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mlevans0 mlevans0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mserranom mserranom merged commit 27352ee into master Jul 17, 2024
@mserranom mserranom deleted the msm-update-mongo-seed-6 branch July 17, 2024 09:43
darvid7 added a commit to darvid7/toolkit that referenced this pull request Apr 14, 2025
with overleaf#270 the prefix of the configuration shouldn't be in the return value.

On a new checkout I ran into 
 
```
---------------------  ERROR  -----------------------
  Invalid MONGO_VERSION: MONGO_VERSION=6.0

  MONGO_VERSION must start with the actual major version of mongo, followed by a dot.
  Example: MONGO_IMAGE=my.dockerhub.com/custom-mongo
           MONGO_VERSION=6.0-custom
---------------------  ERROR  -----------------------
```

removing `\1` fixed it.
@darvid7 darvid7 mentioned this pull request Apr 14, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants