Copy Etag header to OC-Etag for sabre calls #15227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, this is only possible with Sabre 2.1 thanks to its revamped plugin architecture. |
|
👍 looks good |
|
The inspection completed: 2 new issues, 4 updated code elements |
|
Refer to this link for build results (access rights to CI server needed): |
|
👍 Tested and confirmed that this patch works while the previous iteration by @DeepDiver1975 didn't.. |
|
Cool. Let me click the green button then. |
PVince81
pushed a commit
that referenced
this pull request
Mar 27, 2015
Copy Etag header to OC-Etag for sabre calls
|
Note: this fix cannot be backported because the Sabre version in 8.0.x didn't support overwriting headers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DeepDiver1975 @icewind1991
Fix for #9005