[JENKINS] Capabilities manager #15093

apps/files/appinfo/application.php

@@ -1,6 +1,5 @@
 <?php
 /**
- * @author Morris Jobke <[email protected]>
  * @author Roeland Jago Douma <[email protected]>
  * @author Tobias Kaminsky <[email protected]>
  * @author Vincent Petry <[email protected]>
@@ -21,8 +20,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  *
  */
-
-namespace OCA\Files\Appinfo;
+namespace OCA\Files\AppInfo;
 
 use OCA\Files\Controller\ApiController;
 use OCP\AppFramework\App;
@@ -68,5 +66,10 @@ public function __construct(array $urlParams=array()) {
 				$homeFolder
 			);
 		});
+
+		/*
+		 * Register capabilities
+		 */
+		$container->registerCapability('OCA\Files\Capabilities');
 	}
 }

apps/files/appinfo/routes.php

@@ -1,9 +1,9 @@
 <?php
 /**
  * @author Bart Visscher <[email protected]>
- * @author Joas Schilling <[email protected]>
  * @author Lukas Reschke <[email protected]>
  * @author Morris Jobke <[email protected]>
+ * @author Roeland Jago Douma <[email protected]>
  * @author Tobias Kaminsky <[email protected]>
  * @author Tom Needham <[email protected]>
  * @author Vincent Petry <[email protected]>
@@ -24,8 +24,7 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  *
  */
-
-namespace OCA\Files\Appinfo;
+namespace OCA\Files\AppInfo;
 
 $application = new Application();
 $application->registerRoutes(
@@ -82,6 +81,4 @@
 $this->create('download', 'download{file}')
 	->requirements(array('file' => '.*'))
 	->actionInclude('files/download.php');
-
-// Register with the capabilities API
-\OCP\API::register('get', '/cloud/capabilities', array('OCA\Files\Capabilities', 'getCapabilities'), 'files', \OCP\API::USER_AUTH);
+

apps/files/lib/capabilities.php

@@ -1,7 +1,7 @@
 <?php
 /**
  * @author Christopher Schäpers <[email protected]>
- * @author Morris Jobke <[email protected]>
+ * @author Roeland Jago Douma <[email protected]>
  * @author Tom Needham <[email protected]>
  *
  * @copyright Copyright (c) 2015, ownCloud, Inc.
@@ -20,19 +20,28 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  *
  */
-
-namespace OCA\Files; 
 
-class Capabilities {
-
-	public static function getCapabilities() {
-		return new \OC_OCS_Result(array(
-			'capabilities' => array(
-				'files' => array(
-					'bigfilechunking' => true,
-					),
-				),
-			));
+namespace OCA\Files;
+
+use OCP\Capabilities\ICapability;
+
+/**
+ * Class Capabilities
+ *
+ * @package OCA\Files
+ */
+class Capabilities implements ICapability {
+
+	/**
+	 * Return this classes capabilities
+	 *
+	 * @return array
+	 */
+	public function getCapabilities() {
+		return [
+			'files' => [
+				'bigfilechunking' => true,
+			],
+		];
 	}
-
 }

apps/files_external/appinfo/application.php

@@ -21,7 +21,7 @@
  *
  */
 
-namespace OCA\Files_External\Appinfo;
+namespace OCA\Files_External\AppInfo;
 
 use \OCA\Files_External\Controller\AjaxController;
 use \OCP\AppFramework\App;

apps/files_external/appinfo/routes.php

@@ -23,7 +23,7 @@
  *
  */
 
-namespace OCA\Files_External\Appinfo;
+namespace OCA\Files_External\AppInfo;
 
 /**
  * @var $this \OC\Route\Router

apps/files_sharing/appinfo/application.php

@@ -2,6 +2,7 @@
 /**
  * @author Morris Jobke <[email protected]>
  * @author Robin Appelman <[email protected]>
+ * @author Roeland Jago Douma <[email protected]>
  *
  * @copyright Copyright (c) 2015, ownCloud, Inc.
  * @license AGPL-3.0
@@ -20,7 +21,7 @@
  *
  */
 
-namespace OCA\Files_Sharing\Appinfo;
+namespace OCA\Files_Sharing\AppInfo;
 
 use OCA\Files_Sharing\Helper;
 use OCA\Files_Sharing\MountProvider;
@@ -31,6 +32,7 @@
 use OCA\Files_Sharing\Controllers\ShareController;
 use OCA\Files_Sharing\Middleware\SharingCheckMiddleware;
 use \OCP\IContainer;
+use OCA\Files_Sharing\Capabilities;
 
 class Application extends App {
 	public function __construct(array $urlParams = array()) {
@@ -122,6 +124,11 @@ public function __construct(array $urlParams = array()) {
 				$server->getConfig()
 			);
 		});
+
+		/*
+		 * Register capabilities
+		 */
+		$container->registerCapability('OCA\Files_Sharing\Capabilities');
 	}
 
 	public function registerMountProviders() {

apps/files_sharing/appinfo/routes.php

@@ -97,8 +97,3 @@ function() {
 		array('\OCA\Files_Sharing\API\Remote', 'declineShare'),
 		'files_sharing');
 
-// Register with the capabilities API
-API::register('get',
-		'/cloud/capabilities',
-		array('OCA\Files_Sharing\Capabilities', 'getCapabilities'),
-		'files_sharing', API::USER_AUTH);

apps/files_sharing/lib/capabilities.php

@@ -20,39 +20,29 @@
  */
 namespace OCA\Files_Sharing;
 
+use OCP\Capabilities\ICapability;
 use \OCP\IConfig;
 
 /**
  * Class Capabilities
  *
  * @package OCA\Files_Sharing
  */
-class Capabilities {
+class Capabilities implements ICapability {
 
 	/** @var IConfig */
 	private $config;
 
-	/**
-	 * @param IConfig $config
-	 */
 	public function __construct(IConfig $config) {
 		$this->config = $config;
 	}
 
 	/**
-	 * @return \OC_OCS_Result
-	 */
-	public static function getCapabilities() {
-		$config = \OC::$server->getConfig();
-		$cap = new Capabilities($config);
-		return $cap->getCaps();
-	}
-
-
-	/**
-	 * @return \OC_OCS_Result
+	 * Return this classes capabilities
+	 *
+	 * @return array
 	 */
-	public function getCaps() {
+	public function getCapabilities() {
 		$res = [];
 
 		$public = [];
@@ -76,12 +66,8 @@ public function getCaps() {
 
 		$res['resharing'] = $this->config->getAppValue('core', 'shareapi_allow_resharing', 'yes') === 'yes';
 
-
-		return new \OC_OCS_Result([
-			'capabilities' => [
-				'files_sharing' => $res
-				],
-			]);
+		return [
+			'files_sharing' => $res,
+		];
 	}
-
 }

apps/files_sharing/tests/capabilities.php

@@ -36,9 +36,8 @@ class FilesSharingCapabilitiesTest extends \Test\TestCase {
 	 * @return string[]
 	 */
 	private function getFilesSharingPart(array $data) {
-		$this->assertArrayHasKey('capabilities', $data);
-		$this->assertArrayHasKey('files_sharing', $data['capabilities']);
-		return $data['capabilities']['files_sharing'];
+		$this->assertArrayHasKey('files_sharing', $data);
+		return $data['files_sharing'];
 	}
 
 	/**
@@ -53,7 +52,7 @@ private function getResults(array $map) {
 		$stub = $this->getMockBuilder('\OCP\IConfig')->disableOriginalConstructor()->getMock();
 		$stub->method('getAppValue')->will($this->returnValueMap($map));
 		$cap = new Capabilities($stub);
-		$result = $this->getFilesSharingPart($cap->getCaps()->getData());
+		$result = $this->getFilesSharingPart($cap->getCapabilities());
 		return $result;
 	}
 

apps/files_trashbin/appinfo/application.php

@@ -0,0 +1,37 @@
+<?php
+/**
+ * @author Roeland Jago Douma <[email protected]>
+ *
+ * @copyright Copyright (c) 2015, ownCloud, Inc.
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+
+namespace OCA\Files_Trashbin\AppInfo;
+
+use OCP\AppFramework\App;
+
+class Application extends App {
+	public function __construct(array $urlParams = array()) {
+		parent::__construct('files_trashbin', $urlParams);
+
+		$container = $this->getContainer();
+
+		/*
+		 * Register capabilities
+		 */
+		$container->registerCapability('OCA\Files_Trashbin\Capabilities');
+	}
+}

apps/files_trashbin/appinfo/routes.php

@@ -1,9 +1,8 @@
 <?php
 /**
  * @author Georg Ehrke <[email protected]>
- * @author Joas Schilling <[email protected]>
  * @author Lukas Reschke <[email protected]>
- * @author Morris Jobke <[email protected]>
+ * @author Roeland Jago Douma <[email protected]>
  * @author Vincent Petry <[email protected]>
  *
  * @copyright Copyright (c) 2015, ownCloud, Inc.
@@ -22,6 +21,11 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  *
  */
+
+namespace OCA\Files_Trashbin\AppInfo;
+
+$application = new Application();
+
 $this->create('core_ajax_trashbin_preview', 'ajax/preview.php')
 	->actionInclude('files_trashbin/ajax/preview.php');
 $this->create('files_trashbin_ajax_delete', 'ajax/delete.php')
@@ -33,6 +37,3 @@
 $this->create('files_trashbin_ajax_undelete', 'ajax/undelete.php')
 	->actionInclude('files_trashbin/ajax/undelete.php');
 
-
-// Register with the capabilities API
-\OCP\API::register('get', '/cloud/capabilities', array('OCA\Files_Trashbin\Capabilities', 'getCapabilities'), 'files_trashbin', \OCP\API::USER_AUTH);

apps/files_trashbin/lib/capabilities.php

@@ -2,6 +2,7 @@
 /**
  * @author Lukas Reschke <[email protected]>
  * @author Morris Jobke <[email protected]>
+ * @author Roeland Jago Douma <[email protected]>
  *
  * @copyright Copyright (c) 2015, ownCloud, Inc.
  * @license AGPL-3.0
@@ -22,25 +23,26 @@
 
 namespace OCA\Files_Trashbin;
 
+use OCP\Capabilities\ICapability;
 
 /**
  * Class Capabilities
  *
  * @package OCA\Files_Trashbin
  */
-class Capabilities {
+class Capabilities implements ICapability {
 
 	/**
-	 * @return \OC_OCS_Result
+	 * Return this classes capabilities
+	 *
+	 * @return array
 	 */
-	public static function getCapabilities() {
-		return new \OC_OCS_Result(array(
-			'capabilities' => array(
-				'files' => array(
-					'undelete' => true,
-					),
-				),
-			));
+	public function getCapabilities() {
+		return [
+			'files' => [
+				'undelete' => true
+			]
+		];
 	}
 
 }