feat(minifier): fold expr ?? 1 for non-null undetermined expressions
#10687
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10687 will not alter performanceComparing Summary
|
| | Expression::BinaryExpression(_) | ||
| | Expression::UpdateExpression(_) => Some(false), | ||
| Expression::Identifier(id) => match id.name.as_str() { | ||
| "undefined" => Some(true), |
There was a problem hiding this comment.
There are special methods for checking these, they can be global.
I can't recall what they are, try and find them yourself ;-)
| }, | ||
| Expression::LogicalExpression(expr) => { | ||
| let left = Self::is_nullish(&expr.left); | ||
| let right = Self::is_nullish(&expr.right); |
There was a problem hiding this comment.
You don't need to compute the rhs until it is necessary.
No description provided.