Skip to content

test(linter): explicitly disable correctness for clarity #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

test(linter): explicitly disable correctness for clarity #11327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/oxlint/fixtures/nested_config/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"categories": { "correctness": "off"},
"rules": {
"no-console": "error",
"no-debugger": "error"
Expand Down
1 change: 1 addition & 0 deletions apps/oxlint/fixtures/nested_config/oxlint-no-console.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"categories": { "correctness": "off" },
"rules": {
"no-console": "error",
"no-debugger": "off"
Expand Down
1 change: 1 addition & 0 deletions apps/oxlint/fixtures/nested_config/package1-empty-config/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"categories": { "correctness": "off"},
"rules": {}
}
2 changes: 1 addition & 1 deletion .../oxlint/src/snapshots/fixtures__nested_config_--config [email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ working directory: fixtures/nested_config
help: Delete this console statement.

Found 0 warnings and 4 errors.
Finished in <variable>ms on 7 files with 101 rules using 1 threads.
Finished in <variable>ms on 7 files with 1 rules using 1 threads.
----------
CLI result: LintFoundErrors
----------
2 changes: 1 addition & 1 deletion ...apshots/fixtures__nested_config_-A no-console --config [email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ arguments: -A no-console --config oxlint-no-console.json
working directory: fixtures/nested_config
----------
Found 0 warnings and 0 errors.
Finished in <variable>ms on 7 files with 100 rules using 1 threads.
Finished in <variable>ms on 7 files with 0 rules using 1 threads.
----------
CLI result: LintSucceeded
----------
9 changes: 1 addition & 8 deletions apps/oxlint/src/snapshots/fixtures__nested_config_-A [email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,14 @@ working directory: fixtures/nested_config
`----
help: Remove the debugger statement

! ]8;;https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-debugger.html\eslint(no-debugger)]8;;\: `debugger` statement is not allowed
,-[package1-empty-config/debugger.js:1:1]
1 | debugger;
: ^^^^^^^^^
`----
help: Remove the debugger statement

x ]8;;https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-debugger.html\eslint(no-debugger)]8;;\: `debugger` statement is not allowed
,-[package2-no-config/debugger.js:1:1]
1 | debugger;
: ^^^^^^^^^
`----
help: Remove the debugger statement

Found 1 warning and 2 errors.
Found 0 warnings and 2 errors.
Finished in <variable>ms on 7 files using 1 threads.
----------
CLI result: LintFoundErrors
Expand Down
9 changes: 1 addition & 8 deletions apps/oxlint/src/snapshots/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,6 @@ working directory: fixtures/nested_config
`----
help: Remove the debugger statement

! ]8;;https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-debugger.html\eslint(no-debugger)]8;;\: `debugger` statement is not allowed
,-[package1-empty-config/debugger.js:1:1]
1 | debugger;
: ^^^^^^^^^
`----
help: Remove the debugger statement

x ]8;;https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-console.html\eslint(no-console)]8;;\: Unexpected console statement.
,-[package2-no-config/console.ts:1:1]
1 | console.log("test");
Expand All @@ -50,7 +43,7 @@ working directory: fixtures/nested_config
`----
help: Delete this console statement.

Found 1 warning and 5 errors.
Found 0 warnings and 5 errors.
Finished in <variable>ms on 7 files using 1 threads.
----------
CLI result: LintFoundErrors
Expand Down
Loading